+ {% blocktrans trimmed with site_name=site.name %} + See tagged statuses in the local {{ site_name }} community + {% endblocktrans %} +
+{% trans "No activities for this hashtag yet!" %}
+This is interesting " + + '' + + "#bookclub
", + published="2023-02-17T23:12:59.398030+00:00", + to=[], + cc=[], + tag=[ + { + "type": "Edition", + "name": "gerald j. books", + "href": "http://book.com/book", + }, + { + "type": "Hashtag", + "name": "#BookClub", + "href": "https://test-instance.org/hashtag/2", + }, + ], + ) + + instance = update_data.to_model(model=models.Status) + self.assertIsNotNone(instance) + hashtag = models.Hashtag.objects.filter(name="#BookClub").first() + self.assertIsNotNone(hashtag) + self.assertEqual( + instance.content, + "This is interesting " + + f'' + + "#bookclub
", + ) diff --git a/bookwyrm/tests/models/test_status_model.py b/bookwyrm/tests/models/test_status_model.py index 4f0570a3f..177bedb24 100644 --- a/bookwyrm/tests/models/test_status_model.py +++ b/bookwyrm/tests/models/test_status_model.py @@ -265,7 +265,7 @@ class Status(TestCase): self.assertEqual(activity["attachment"][0]["type"], "Document") self.assertTrue( re.match( - r"https:\/\/your.domain.here\/images\/covers\/test_[A-z0-9]+.jpg", + r"https:\/\/your.domain.here\/images\/covers\/test(_[A-z0-9]+)?.jpg", activity["attachment"][0]["url"], ) ) diff --git a/bookwyrm/tests/views/test_hashtag.py b/bookwyrm/tests/views/test_hashtag.py new file mode 100644 index 000000000..d3115dbce --- /dev/null +++ b/bookwyrm/tests/views/test_hashtag.py @@ -0,0 +1,197 @@ +""" tests for hashtag view """ +from unittest.mock import patch + +from django.contrib.auth.models import AnonymousUser +from django.http import Http404 +from django.template.response import TemplateResponse +from django.test import TestCase +from django.test.client import RequestFactory + +from bookwyrm import models, views +from bookwyrm.tests.validate_html import validate_html + + +class HashtagView(TestCase): + """hashtag view""" + + def setUp(self): + self.factory = RequestFactory() + with patch("bookwyrm.suggested_users.rerank_suggestions_task.delay"), patch( + "bookwyrm.activitystreams.populate_stream_task.delay" + ), patch("bookwyrm.lists_stream.populate_lists_task.delay"): + self.local_user = models.User.objects.create_user( + "mouse@local.com", + "mouse@mouse.com", + "mouseword", + local=True, + localname="mouse", + remote_id="https://example.com/users/mouse", + ) + self.follower_user = models.User.objects.create_user( + "follower@local.com", + "follower@email.com", + "followerword", + local=True, + localname="follower", + remote_id="https://example.com/users/follower", + ) + self.local_user.followers.add(self.follower_user) + self.other_user = models.User.objects.create_user( + "other@local.com", + "other@email.com", + "otherword", + local=True, + localname="other", + remote_id="https://example.com/users/other", + ) + + self.work = models.Work.objects.create(title="Test Work") + self.book = models.Edition.objects.create( + title="Example Edition", + remote_id="https://example.com/book/1", + parent_work=self.work, + ) + + self.hashtag_bookclub = models.Hashtag.objects.create(name="#BookClub") + with patch( + "bookwyrm.models.activitypub_mixin.broadcast_task.apply_async" + ), patch("bookwyrm.activitystreams.add_status_task.delay"): + self.statuses_bookclub = [ + models.Comment.objects.create( + book=self.book, user=self.local_user, content="#BookClub" + ), + ] + for status in self.statuses_bookclub: + status.mention_hashtags.add(self.hashtag_bookclub) + + self.anonymous_user = AnonymousUser + self.anonymous_user.is_authenticated = False + models.SiteSettings.objects.create() + + def test_hashtag_page(self): + """just make sure it loads""" + view = views.Hashtag.as_view() + request = self.factory.get("") + request.user = self.local_user + + result = view(request, self.hashtag_bookclub.id) + + self.assertIsInstance(result, TemplateResponse) + validate_html(result.render()) + self.assertEqual(result.status_code, 200) + self.assertEqual(len(result.context_data["activities"]), 1) + + def test_privacy_direct(self): + """ensure statuses with privacy set to direct are always filtered out""" + view = views.Hashtag.as_view() + request = self.factory.get("") + + hashtag = models.Hashtag.objects.create(name="#test") + with patch( + "bookwyrm.models.activitypub_mixin.broadcast_task.apply_async" + ), patch("bookwyrm.activitystreams.add_status_task.delay"): + status = models.Comment.objects.create( + user=self.local_user, book=self.book, content="#test", privacy="direct" + ) + status.mention_hashtags.add(hashtag) + + for user in [ + self.local_user, + self.follower_user, + self.other_user, + self.anonymous_user, + ]: + request.user = user + result = view(request, hashtag.id) + self.assertNotIn(status, result.context_data["activities"]) + + def test_privacy_unlisted(self): + """ensure statuses with privacy set to unlisted are always filtered out""" + view = views.Hashtag.as_view() + request = self.factory.get("") + + hashtag = models.Hashtag.objects.create(name="#test") + with patch( + "bookwyrm.models.activitypub_mixin.broadcast_task.apply_async" + ), patch("bookwyrm.activitystreams.add_status_task.delay"): + status = models.Comment.objects.create( + user=self.local_user, + book=self.book, + content="#test", + privacy="unlisted", + ) + status.mention_hashtags.add(hashtag) + + for user in [ + self.local_user, + self.follower_user, + self.other_user, + self.anonymous_user, + ]: + request.user = user + result = view(request, hashtag.id) + self.assertNotIn(status, result.context_data["activities"]) + + def test_privacy_following(self): + """ensure only creator and followers can see statuses with privacy + set to followers""" + view = views.Hashtag.as_view() + request = self.factory.get("") + + hashtag = models.Hashtag.objects.create(name="#test") + with patch( + "bookwyrm.models.activitypub_mixin.broadcast_task.apply_async" + ), patch("bookwyrm.activitystreams.add_status_task.delay"): + status = models.Comment.objects.create( + user=self.local_user, + book=self.book, + content="#test", + privacy="followers", + ) + status.mention_hashtags.add(hashtag) + + for user in [self.local_user, self.follower_user]: + request.user = user + result = view(request, hashtag.id) + self.assertIn(status, result.context_data["activities"]) + + for user in [self.other_user, self.anonymous_user]: + request.user = user + result = view(request, hashtag.id) + self.assertNotIn(status, result.context_data["activities"]) + + def test_not_found(self): + """make sure 404 is rendered""" + view = views.Hashtag.as_view() + request = self.factory.get("") + request.user = self.local_user + + with self.assertRaises(Http404): + view(request, 42) + + def test_empty(self): + """hashtag without any statuses should still render""" + view = views.Hashtag.as_view() + request = self.factory.get("") + request.user = self.local_user + + hashtag_empty = models.Hashtag.objects.create(name="#empty") + result = view(request, hashtag_empty.id) + + self.assertIsInstance(result, TemplateResponse) + validate_html(result.render()) + self.assertEqual(result.status_code, 200) + self.assertEqual(len(result.context_data["activities"]), 0) + + def test_logged_out(self): + """make sure it loads all activities""" + view = views.Hashtag.as_view() + request = self.factory.get("") + request.user = self.anonymous_user + + result = view(request, self.hashtag_bookclub.id) + + self.assertIsInstance(result, TemplateResponse) + validate_html(result.render()) + self.assertEqual(result.status_code, 200) + self.assertEqual(len(result.context_data["activities"]), 1) diff --git a/bookwyrm/tests/views/test_status.py b/bookwyrm/tests/views/test_status.py index 203ec57dd..d02c71374 100644 --- a/bookwyrm/tests/views/test_status.py +++ b/bookwyrm/tests/views/test_status.py @@ -6,7 +6,7 @@ from django.test import TestCase, TransactionTestCase from django.test.client import RequestFactory from bookwyrm import forms, models, views -from bookwyrm.views.status import find_mentions +from bookwyrm.views.status import find_mentions, find_or_create_hashtags from bookwyrm.settings import DOMAIN from bookwyrm.tests.validate_html import validate_html @@ -95,6 +95,7 @@ class StatusViews(TestCase): local=True, localname="nutria", ) + self.existing_hashtag = models.Hashtag.objects.create(name="#existing") with patch("bookwyrm.models.user.set_remote_server"): self.remote_user = models.User.objects.create_user( "rat", @@ -333,6 +334,71 @@ class StatusViews(TestCase): result = find_mentions(self.local_user, "@beep@beep.com") self.assertEqual(result, {}) + def test_create_status_hashtags(self, *_): + """#mention a hashtag in a post""" + view = views.CreateStatus.as_view() + form = forms.CommentForm( + { + "content": "this is an #EXISTING hashtag but all uppercase, " + + "this one is #NewTag.", + "user": self.local_user.id, + "book": self.book.id, + "privacy": "public", + } + ) + request = self.factory.post("", form.data) + request.user = self.local_user + + view(request, "comment") + status = models.Status.objects.get() + + hashtags = models.Hashtag.objects.all() + self.assertEqual(len(hashtags), 2) + self.assertEqual(list(status.mention_hashtags.all()), list(hashtags)) + + hashtag_exising = models.Hashtag.objects.filter(name="#existing").first() + hashtag_new = models.Hashtag.objects.filter(name="#NewTag").first() + self.assertEqual( + status.content, + "this is an " + + f'' + + "#EXISTING hashtag but all uppercase, this one is " + + f'' + + "#NewTag.
", + ) + + def test_find_or_create_hashtags(self, *_): + """detect and look up #hashtags""" + result = find_or_create_hashtags("no hashtag to be found here") + self.assertEqual(result, {}) + + result = find_or_create_hashtags("#existing") + self.assertEqual(result["#existing"], self.existing_hashtag) + + result = find_or_create_hashtags("leading text #existing") + self.assertEqual(result["#existing"], self.existing_hashtag) + + result = find_or_create_hashtags("leading #existing trailing") + self.assertEqual(result["#existing"], self.existing_hashtag) + + self.assertIsNone(models.Hashtag.objects.filter(name="new").first()) + result = find_or_create_hashtags("leading #new trailing") + new_hashtag = models.Hashtag.objects.filter(name="#new").first() + self.assertIsNotNone(new_hashtag) + self.assertEqual(result["#new"], new_hashtag) + + result = find_or_create_hashtags("leading #existing #new trailing") + self.assertEqual(result["#existing"], self.existing_hashtag) + self.assertEqual(result["#new"], new_hashtag) + + result = find_or_create_hashtags("#Braunbär") + hashtag = models.Hashtag.objects.filter(name="#Braunbär").first() + self.assertEqual(result["#Braunbär"], hashtag) + + result = find_or_create_hashtags("#ひぐま") + hashtag = models.Hashtag.objects.filter(name="#ひぐま").first() + self.assertEqual(result["#ひぐま"], hashtag) + def test_format_links_simple_url(self, *_): """find and format urls into a tags""" url = "http://www.fish.com/" diff --git a/bookwyrm/urls.py b/bookwyrm/urls.py index 3fbf7dda1..b785a27a2 100644 --- a/bookwyrm/urls.py +++ b/bookwyrm/urls.py @@ -356,6 +356,15 @@ urlpatterns = [ name="notifications", ), re_path(r"^directory/?", views.Directory.as_view(), name="directory"), + # hashtag + re_path( + r"^hashtag/(?P