From 72b4e7da76c1f44e970ec0ff60d9c6eb42499277 Mon Sep 17 00:00:00 2001
From: Mouse Reeve <mousereeve@riseup.net>
Date: Sun, 10 May 2020 11:29:10 -0700
Subject: [PATCH] Small code cleanup

---
 fedireads/connectors/abstract_connector.py  | 25 ++++++++++++---------
 fedireads/connectors/fedireads_connector.py |  2 +-
 fedireads/incoming.py                       |  2 +-
 3 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/fedireads/connectors/abstract_connector.py b/fedireads/connectors/abstract_connector.py
index 83729bb3f..79707ba5a 100644
--- a/fedireads/connectors/abstract_connector.py
+++ b/fedireads/connectors/abstract_connector.py
@@ -17,16 +17,19 @@ class AbstractConnector(ABC):
 
         self.book_mappings = {}
 
-        self.base_url = info.base_url
-        self.books_url = info.books_url
-        self.covers_url = info.covers_url
-        self.search_url = info.search_url
-        self.key_name = info.key_name
-        self.max_query_count = info.max_query_count
-        self.name = info.name
-        self.local = info.local
-        self.id = info.id
-        self.identifier = info.identifier
+        fields = [
+            'base_url',
+            'books_url',
+            'covers_url',
+            'search_url',
+            'key_name',
+            'max_query_count',
+            'name',
+            'identifier',
+            'local'
+        ]
+        for field in fields:
+            setattr(self, field, getattr(info, field))
 
 
     def is_available(self):
@@ -235,7 +238,7 @@ def get_data(url):
     return data
 
 
-class SearchResult:
+class SearchResult(object):
     ''' standardized search result object '''
     def __init__(self, title, key, author, year):
         self.title = title
diff --git a/fedireads/connectors/fedireads_connector.py b/fedireads/connectors/fedireads_connector.py
index 83705e661..65e342825 100644
--- a/fedireads/connectors/fedireads_connector.py
+++ b/fedireads/connectors/fedireads_connector.py
@@ -131,7 +131,7 @@ class Connector(AbstractConnector):
 
 
 def get_cover(cover_url):
-    ''' ask openlibrary for the cover '''
+    ''' download the cover '''
     image_name = cover_url.split('/')[-1]
     response = requests.get(cover_url)
     if not response.ok:
diff --git a/fedireads/incoming.py b/fedireads/incoming.py
index 206da9d4c..580d978f5 100644
--- a/fedireads/incoming.py
+++ b/fedireads/incoming.py
@@ -310,7 +310,7 @@ def handle_boost(activity):
 
 @app.task
 def handle_tag(activity):
-    ''' someone is tagging or shelving a book '''
+    ''' someone is tagging a book '''
     user = get_or_create_remote_user(activity['actor'])
     if not user.local:
         book = activity['target']['id']