From 78f50034079eb691c0122a8b0359ed72fea3d139 Mon Sep 17 00:00:00 2001 From: Hugh Rundle Date: Tue, 5 Oct 2021 08:09:24 +1100 Subject: [PATCH] lint raise_visible_to_user Don't return True unnecessarily --- bookwyrm/models/base_model.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bookwyrm/models/base_model.py b/bookwyrm/models/base_model.py index d52c368ec..058aa4788 100644 --- a/bookwyrm/models/base_model.py +++ b/bookwyrm/models/base_model.py @@ -79,14 +79,14 @@ class BookWyrmModel(models.Model): and self.mention_users.filter(id=viewer.id).first() ): - return True + return # you can see groups of which you are a member if ( hasattr(self, "memberships") and self.memberships.filter(user=viewer).exists() ): - return True + return # you can see objects which have a group of which you are a member if hasattr(self, "group"): @@ -94,7 +94,7 @@ class BookWyrmModel(models.Model): hasattr(self.group, "memberships") and self.group.memberships.filter(user=viewer).exists() ): - return True + return raise Http404()