zedfrigg/bookwyrm
1
0
Fork 0
Code Activity

Check permissions automatically on form save

Browse source
This commit is contained in:
Mouse Reeve 2022-08-05 09:51:55 -07:00
parent 2894aa37a2
commit 8f79b362f8
10 changed files with 19 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

3
bookwyrm/views/shelf/shelf.py
View file

@ -113,7 +113,6 @@ class Shelf(View):
"""edit a shelf"""
user = get_user_from_username(request.user, username)
shelf = get_object_or_404(user.shelf_set, identifier=shelf_identifier)
shelf.raise_not_editable(request.user)
# you can't change the name of the default shelves
if not shelf.editable and request.POST.get("name") != shelf.name:
@ -122,7 +121,7 @@ class Shelf(View):
form = forms.ShelfForm(request.POST, instance=shelf)
if not form.is_valid():
return redirect(shelf.local_path)
shelf = form.save()
shelf = form.save(request)
return redirect(shelf.local_path)

4
bookwyrm/views/shelf/shelf_actions.py
View file

@ -15,9 +15,7 @@ def create_shelf(request):
if not form.is_valid():
return redirect("user-shelves", request.user.localname)
shelf = form.save(commit=False)
shelf.raise_not_editable(request.user)
shelf.save()
shelf = form.save(request)
return redirect(shelf.local_path)