From 673b05e3375bee6cdd39ad3ea2bf7c060937216b Mon Sep 17 00:00:00 2001
From: Jake Stanger <mail@jstanger.dev>
Date: Sun, 22 Jun 2025 16:23:10 +0100
Subject: [PATCH] fix: panic when module controller errors

If an individual controller fails, it will now error independently and allow other modules to continue loading.

Fixes #1057
---
 src/bar.rs        |  7 +++++--
 src/config/mod.rs | 52 ++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 54 insertions(+), 5 deletions(-)

diff --git a/src/bar.rs b/src/bar.rs
index 1056f46..6d5444f 100644
--- a/src/bar.rs
+++ b/src/bar.rs
@@ -10,7 +10,7 @@ use gtk::{Application, ApplicationWindow, Orientation, Window, WindowType};
 use gtk_layer_shell::LayerShell;
 use std::rc::Rc;
 use std::time::Duration;
-use tracing::{debug, info};
+use tracing::{debug, error, info};
 
 #[derive(Debug, Clone)]
 enum Inner {
@@ -381,7 +381,10 @@ fn add_modules(
     let module_factory = BarModuleFactory::new(ironbar.clone(), popup.clone()).into();
 
     for config in modules {
-        config.create(&module_factory, content, info)?;
+        let name = config.name();
+        if let Err(err) = config.create(&module_factory, content, info) {
+            error!("failed to create module {name}: {:?}", err);
+        }
     }
 
     Ok(())
diff --git a/src/config/mod.rs b/src/config/mod.rs
index 0fb7875..2d32091 100644
--- a/src/config/mod.rs
+++ b/src/config/mod.rs
@@ -45,11 +45,10 @@ use crate::modules::workspaces::WorkspacesModule;
 use crate::modules::{AnyModuleFactory, ModuleFactory, ModuleInfo};
 use cfg_if::cfg_if;
 use color_eyre::Result;
-use serde::Deserialize;
-use std::collections::HashMap;
-
 #[cfg(feature = "schema")]
 use schemars::JsonSchema;
+use serde::Deserialize;
+use std::collections::HashMap;
 
 pub use self::common::{CommonConfig, ModuleJustification, ModuleOrientation, TransitionType};
 pub use self::layout::LayoutConfig;
@@ -153,6 +152,53 @@ impl ModuleConfig {
             Self::Workspaces(module) => create!(module),
         }
     }
+
+    pub fn name(&self) -> String {
+        match self {
+            #[cfg(feature = "bindmode")]
+            ModuleConfig::Bindmode(_) => "Bindmode",
+            #[cfg(feature = "cairo")]
+            ModuleConfig::Cairo(_) => "Cario",
+            #[cfg(feature = "clipboard")]
+            ModuleConfig::Clipboard(_) => "Clipboard",
+            #[cfg(feature = "clock")]
+            ModuleConfig::Clock(_) => "Clock",
+            #[cfg(feature = "custom")]
+            ModuleConfig::Custom(_) => "Custom",
+            #[cfg(feature = "focused")]
+            ModuleConfig::Focused(_) => "Focused",
+            #[cfg(feature = "keyboard")]
+            ModuleConfig::Keyboard(_) => "Keyboard",
+            #[cfg(feature = "label")]
+            ModuleConfig::Label(_) => "Label",
+            #[cfg(feature = "launcher")]
+            ModuleConfig::Launcher(_) => "Launcher",
+            #[cfg(feature = "menu")]
+            ModuleConfig::Menu(_) => "Menu",
+            #[cfg(feature = "music")]
+            ModuleConfig::Music(_) => "Music",
+            #[cfg(feature = "network_manager")]
+            ModuleConfig::NetworkManager(_) => "NetworkManager",
+            #[cfg(feature = "notifications")]
+            ModuleConfig::Notifications(_) => "Notifications",
+            #[cfg(feature = "script")]
+            ModuleConfig::Script(_) => "Script",
+            #[cfg(feature = "sys_info")]
+            ModuleConfig::SysInfo(_) => "SysInfo",
+            #[cfg(feature = "tray")]
+            ModuleConfig::Tray(_) => "Tray",
+            #[cfg(feature = "upower")]
+            ModuleConfig::Upower(_) => "UPower",
+            #[cfg(feature = "volume")]
+            ModuleConfig::Volume(_) => "Volume",
+            #[cfg(feature = "workspaces")]
+            ModuleConfig::Workspaces(_) => "Workspaces",
+            // in case no modules are compiled
+            #[allow(unreachable_patterns)]
+            _ => "",
+        }
+        .to_string()
+    }
 }
 
 #[derive(Debug, Clone)]