zedfrigg/ironbar
1
0
Fork 0
mirror of https://github.com/Zedfrigg/ironbar.git synced 2025-08-17 14:51:04 +02:00
Code Activity

fix(regression): GTK refactor causing updates to be missed

Browse source 
Regression introduced by recent GTK refactor.

The `glib_recv` macros  previously using the passed in expression as the receiver, which was causing a new receiver to be created *every* time an event was received. This caused some peculiar behaviours where some events just never got through if sent too close to each other.

This was most obvious in the `workspaces` module.

Fixes #381
This commit is contained in:
Jake Stanger 2023-12-31 00:50:03 +00:00
parent b2a37a32b0
commit b4d75450ac
No known key found for this signature in database
GPG key ID: C51FC8F9CB0BEA61
14 changed files with 27 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/modules/upower.rs
View file

@ -181,7 +181,7 @@ impl Module<gtk::Button> for UpowerModule {
label.set_angle(info.bar_position.get_angle());
let format = self.format.clone();
let mut rx = context.subscribe();
let rx = context.subscribe();
glib_recv!(rx, properties => {
let format = format.replace("{percentage}", &properties.percentage.to_string());
let icon_name = String::from("icon:") + &properties.icon_name;
@ -203,7 +203,7 @@ impl Module<gtk::Button> for UpowerModule {
fn into_popup(
self,
_tx: mpsc::Sender<Self::ReceiveMessage>,
mut rx: broadcast::Receiver<Self::SendMessage>,
rx: broadcast::Receiver<Self::SendMessage>,
_info: &ModuleInfo,
) -> Option<gtk::Box>
where