From 189975791f6424eca85fcfd76b796e5e9f9fb47f Mon Sep 17 00:00:00 2001 From: Jake Stanger Date: Sat, 10 Aug 2024 13:41:22 +0100 Subject: [PATCH] refactor(mpris): better logging, avoid panic on dbus error --- src/clients/music/mpris.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/clients/music/mpris.rs b/src/clients/music/mpris.rs index d505560..2b5e643 100644 --- a/src/clients/music/mpris.rs +++ b/src/clients/music/mpris.rs @@ -47,9 +47,12 @@ impl Client { )) if transport_error.name() == Some(NO_ACTIVE_PLAYER) || transport_error.name() == Some(NO_REPLY) => { - Vec::new() + vec![] + } + _ => { + error!("D-Bus error getting MPRIS players: {e:?}"); + vec![] } - _ => panic!("Failed to connect to D-Bus"), }); // Acquire the lock of current_player before players to avoid deadlock. // There are places where we lock on current_player and players, but we always lock on current_player first.