From ff359f61c2e13906b2dc5121cfcc9e1cef59c251 Mon Sep 17 00:00:00 2001
From: Jake Stanger <mail@jstanger.dev>
Date: Tue, 20 May 2025 15:41:04 +0100
Subject: [PATCH] fix(launcher): regression - favourites in wrong order

Fixes #997
---
 src/modules/launcher/mod.rs | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/modules/launcher/mod.rs b/src/modules/launcher/mod.rs
index 5870c59..0cad0f5 100644
--- a/src/modules/launcher/mod.rs
+++ b/src/modules/launcher/mod.rs
@@ -269,10 +269,16 @@ impl Module<gtk::Box> for LauncherModule {
             }
 
             {
-                let items = lock!(items);
-                let items = items.iter();
-                for (_, item) in items {
-                    tx.send_update_spawn(LauncherUpdate::AddItem(item.clone()));
+                let items = {
+                    let items = lock!(items);
+                    items
+                        .iter()
+                        .map(|(_, item)| item.clone())
+                        .collect::<Vec<_>>() // need to collect to be able to drop lock
+                };
+
+                for item in items {
+                    tx.send_update(LauncherUpdate::AddItem(item)).await;
                 }
             }